• Windex007@lemmy.world
    link
    fedilink
    arrow-up
    26
    ·
    1 year ago

    If code reviews in your org are glorified “styleguide checks”, then they are not really code reviews at all.

    Also, if you’re only getting design input at code review time, that’s WWAAYY too late in the process.

    Code reviews should be:

    • Establishing that the code has proper test coverage (functional correctness VIA coverage, not code observation)

    • Establishing that it doesn’t have unintended consequences in the ** implementation** (making db calls in a loop, exposing secure information, etc)

    • That the implementation is of the high-level design that was already established and agreed upon by the larger development unit.

    • A opportunity to ask questions to learn from whoever wrote the code

    • An opportunity for the reviewers to teach techniques that could have helped in the code

    • neil@programming.dev
      link
      fedilink
      arrow-up
      25
      ·
      1 year ago

      You missed one:

      • To let others at least have some insight into what you’re doing so you can take a freakin’ vacation every once in a while